Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2016 historical capacity and generation data #167

Merged
merged 7 commits into from
Oct 29, 2020
Merged

Add 2016 historical capacity and generation data #167

merged 7 commits into from
Oct 29, 2020

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Sep 14, 2020

Purpose

Add 2016 historical data to the code base, write attribution file and refactor code to use the 2016 historical data.

Where to look

  • ATTRIBUTION.md describes the files in postreise/data
  • 2016_Historical_USA_TAMU_Capacity_MW.csv and 2016_Historical_USA_TAMU_Generation_GWh.csv have beedn added to postreise/data
  • the summarize module have been refactored to use the above USA generation file. Note that, previously the calculation of the Generation in Texas and the Western/Eastern interconnect was incorrect (usual issue with El Paso, East Texas and Texas Penhandle). The tests have been refactored accordingly.

Time estimate

20min

@BainanXia
Copy link
Collaborator

@rouille Yes, we do. You can find those tables in Dropbox (Gates Ventures)/BreakthroughEnergySciences/Results/Scenarios/ScenarioRuns/Western_Texas_Nuclear_Fix_Scenario_Rerun_05_30_20/USA 2016 Basecase

@rouille
Copy link
Collaborator Author

rouille commented Sep 15, 2020

@BainanXia, I don't understand how we can have generation from dfo in e.g, Arizona and California with 0 capacity. It is possible that 2016_Historical_USA_TAMU_Generation_GWh.csv that I added (2900b31) is incorrect.

@BainanXia
Copy link
Collaborator

@rouille I believe that table records historical references (from EIA I presume), not our results. We don't have any dfo generators in Western, hence, there is no way to have dfo generation in the results.

@rouille
Copy link
Collaborator Author

rouille commented Sep 15, 2020

@rouille I believe that table records historical references (from EIA I presume), not our results. We don't have any dfo generators in Western, hence, there is no way to have dfo generation in the results.

@BainanXia, So the file 2016_Historical_USA_TAMU_Generation_GWh.csv that I added (2900b31) is incorrect since it is supposed to be the historical generation. Where I can find the correct file?

@kasparm kasparm removed this from the Airpocalypse milestone Oct 6, 2020
@BainanXia
Copy link
Collaborator

@rouille I believe this has been resolved after we discussed with @danlivengood and we had dfo numbers added in the table which we don't use them in our simulations for now, right?

@rouille
Copy link
Collaborator Author

rouille commented Oct 6, 2020

@rouille I believe this has been resolved after we discussed with @danlivengood and we had dfo numbers added in the table which we don't use them in our simulations for now, right?

I still need to work on this PR. I will likely get back to it next sprint. Yes, thank you @danlivengood @BainanXia for generating the files.

@rouille rouille force-pushed the ben/data branch 6 times, most recently from ae135a2 to dd02a01 Compare October 23, 2020 04:47
@rouille rouille force-pushed the ben/data branch 2 times, most recently from 9d95e16 to 4a5799c Compare October 27, 2020 05:23
@rouille rouille requested a review from kasparm October 27, 2020 05:30
@rouille
Copy link
Collaborator Author

rouille commented Oct 27, 2020

@BainanXia, @danielolsen, @jon-hagg and @kasparm, this PR is ready to go.

@kasparm
Copy link
Contributor

kasparm commented Oct 28, 2020

Attribution file looks good. Thanks @rouille

Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking through the files and they are as expected. All tests passed. Thanks for taking care of this.

@rouille rouille merged commit 158d90e into develop Oct 29, 2020
@rouille rouille deleted the ben/data branch October 29, 2020 19:04
@ahurli ahurli mentioned this pull request Mar 16, 2021
@rouille rouille changed the title 2016 historical data Add 2016 historical capacity and generation data Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants