-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2016 historical capacity and generation data #167
Conversation
@rouille Yes, we do. You can find those tables in |
@BainanXia, I don't understand how we can have generation from |
@rouille I believe that table records historical references (from EIA I presume), not our results. We don't have any dfo generators in Western, hence, there is no way to have dfo generation in the results. |
@BainanXia, So the file |
@rouille I believe this has been resolved after we discussed with @danlivengood and we had dfo numbers added in the table which we don't use them in our simulations for now, right? |
I still need to work on this PR. I will likely get back to it next sprint. Yes, thank you @danlivengood @BainanXia for generating the files. |
ae135a2
to
dd02a01
Compare
9d95e16
to
4a5799c
Compare
@BainanXia, @danielolsen, @jon-hagg and @kasparm, this PR is ready to go. |
Attribution file looks good. Thanks @rouille |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking through the files and they are as expected. All tests passed. Thanks for taking care of this.
Purpose
Add 2016 historical data to the code base, write attribution file and refactor code to use the 2016 historical data.
Where to look
summarize
module have been refactored to use the above USA generation file. Note that, previously the calculation of the Generation in Texas and the Western/Eastern interconnect was incorrect (usual issue with El Paso, East Texas and Texas Penhandle). The tests have been refactored accordingly.Time estimate
20min