feat: parse results including geothermal and dfo gens #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
The 'possible' list has been updated to be based on a pre-existing set of keys. |
kasparm
reviewed
Aug 2, 2019
| for r in resources: | ||
| if r not in possible: | ||
| if r not in self.type2label.keys(): |
There was a problem hiding this comment.
self is not accessible in function, need to pass it.
There was a problem hiding this comment.
Is there a reason we are using staticmethods in most of the _check functions, but not all?
There was a problem hiding this comment.
That is a question for @rouille ...
This class will need some rework but for now we try to get it to work. Let me do the changes.
kasparm
approved these changes
Aug 5, 2019
kasparm
force-pushed
the
add_geothermal_dfo
branch
from
be67e9e to
967f9b5
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parsing capability for geothermal and dfo (fuel oil) generators. Slight re-organization to improve readability.