Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in tox.ini #182

Merged
merged 1 commit into from
Oct 15, 2020
Merged

fix: typo in tox.ini #182

merged 1 commit into from
Oct 15, 2020

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Oct 15, 2020

Purpose

Typo - skipdist is not a real tox config key so it's ignored, which means we are doing more installation than necessary.
Changed to the correct value - reference

Time to review

1 min - I tested locally by recreating the tox environment to make sure we actually save time by doing this

@jenhagg jenhagg self-assigned this Oct 15, 2020
@jenhagg jenhagg added this to the spiders milestone Oct 15, 2020
@jenhagg jenhagg merged commit 6ef926e into develop Oct 15, 2020
@jenhagg jenhagg deleted the jon/tox branch October 15, 2020 20:37
@ahurli ahurli mentioned this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants