Regenerate lock file #183
Merged
Regenerate lock file #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Previously it would parse 3.0 to 3? |
rouille
approved these changes
Oct 16, 2020
The test passed with the previous version of pandas so I would say it was probably casting the entire column to |
that's correct, just tested it out again. after the pandas update it would still be an int, which won't raise the error |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Package were removed from powersimdata, so we should update the lock file here to reflect that.
What the code is doing
The test change is to fix a failure introduced by pandas minor version update. Original code no longer has an effect on the data frame, causing the test to fail. We fix by explicitly casting the column to a float.
Testing
Ran pytest
Time estimate
3 min