-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wecc congestion stats #20
Conversation
I'm currently adding a version of the wecc congestion stats that will allow the user to pick the congestion thresholds. Will commit to the branch as this work is completed. |
I believe your branch should be merged to |
I changed the branch to merge into to develop. Also removed the pycache binary files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, create a function that only takes an instance of the scenario object and returns the congestion analysis.
I've fixed several of the issues identified: removing name from input parameter, removing function from within the function, and adding doc strings to all the functions for documentation. I am still working on 'create a function that only takes an instance of the scenario object and returns the congestion analysis" |
I've successfully created a function that only takes an instance of the scenario object and returns the congestion analysis. It's a bit slow, taking 5 min or so to run -- I will work on speeding it up. |
Per conversation earlier today with Kaspar, I've put the mapping function into transmission.py, and a demo in the demo folder. I removed the outdated p-value based function, and associated notebooks (mapping and analysis). |
Per conversation today with Kaspar, will move the mapping function to it's own py script in the analyze folder of PostREISE. Also will remove unnecessary imports and will adhere to punctuation conventions using spaces etc. |
d4ddbc9
to
4f5b31e
Compare
In function branch data frame before call to
branch data frame after call to
If you want to learn more about passage by copy/reference, mtability/immutability, I recommend these two blog posts: I am going to rewrite this function. |
update: I spoke with Ben about this and agree that rewriting to not directly modify the dataframe (preserve original) makes sense. Also that rateA == 0 capacity should be NA as it isn't applicable. When rateA == 0 that means capacity is unconstrained on branch. It will not be congested and therefore isn't included in congestion analyses. |
Waiting for changes by @victoriahunt and @danielolsen before merging into develop. |
Confirmed with Ben last week that his code calculates same values that mine did. It is ready to be merged. |
I talked to @kasparm and @rouille and @victoriahunt and didn't learn of any changes that I need to make to this branch. |
9b07332
to
783d27e
Compare
The las commit reorganize the modules: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will do the rebase tomorrow and merge into develop.
3bd55fe
to
c02f770
Compare
WECC congestion statistics code added to transmission.py.
Function to generate utilization as proportion of capacity (power flow divided by capacity) added to transmission.py.