Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better formatting for auto generated PR description #229

Merged
merged 1 commit into from
Feb 26, 2021
Merged

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Feb 25, 2021

Purpose

When we run the workflow to update packages, add a summary to the PR that is created.

What the code is doing

  • Parse the json into additions/deletions/updates using jq
  • Escape newlines in each one so they can be set as output variables (since github will truncate multi line outputs)

Testing

Manually triggered the workflow and checked the resulting PR #228

Time estimate

5 min

@jenhagg jenhagg self-assigned this Feb 25, 2021
@jenhagg jenhagg added this to the Texas On My Mind milestone Feb 25, 2021
@jenhagg jenhagg requested a review from rouille February 25, 2021 22:19
Copy link
Collaborator

@rouille rouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output looks good. Also never heard of jq, thanks for introducing it to me.

@jenhagg jenhagg merged commit d03b431 into develop Feb 26, 2021
@jenhagg jenhagg deleted the jon/action branch February 26, 2021 00:22
@jenhagg
Copy link
Collaborator Author

jenhagg commented Feb 26, 2021

The output looks good. Also never heard of jq, thanks for introducing it to me.

Yeah jq is nice, this is the first time I'm using it. Actually, I bet this whole thing could have been a jq program.

@rouille
Copy link
Collaborator

rouille commented Feb 26, 2021

The output looks good. Also never heard of jq, thanks for introducing it to me.

Yeah jq is nice, this is the first time I'm using it. Actually, I bet this whole thing could have been a jq program.

As you know, I am a big fan of sed & awk (I have the book) and it seems that jq accomplishes similar things.

@ahurli ahurli mentioned this pull request Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants