Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add net demand to stacked generation plot #32

Merged
merged 3 commits into from
Sep 17, 2019
Merged

Add net demand to stacked generation plot #32

merged 3 commits into from
Sep 17, 2019

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Sep 13, 2019

Added net demand (demand -solar - wind) to the stacked generation plot. I have also fixed the time zone for New Mexico and Montana.

@rouille rouille added the new feature Feature that is currently in progress. label Sep 13, 2019
@rouille rouille requested a review from kasparm September 13, 2019 18:33
@rouille rouille self-assigned this Sep 13, 2019
kasparm
kasparm reviewed Sep 17, 2019
View reviewed changes
Copy link
Contributor

@kasparm kasparm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On first sight this is working fine.
Would there be a way to turn this feature on and off?

@rouille
Copy link
Collaborator Author

rouille commented Sep 17, 2019

Unfortunately, it is complicated to tailor each analysis (curtailment, stack, chart, correlation, ...) through the AnalyzePG object since we use one constructor for each analysis.

@kasparm kasparm self-requested a review September 17, 2019 22:30
kasparm
kasparm approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@kasparm kasparm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Just make sure to fix the commit history (remove last commit and rebase)

@rouille rouille merged commit e0c82be into develop Sep 17, 2019
@rouille rouille deleted the add_netdemand branch September 17, 2019 23:02
@ahurli ahurli mentioned this pull request Mar 16, 2021
Merged
@rouille rouille changed the title Add netdemand Add net demand to stacked generation plot Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasparm kasparm kasparm approved these changes

Assignees
No one assigned
Labels
new feature Feature that is currently in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rouille @kasparm