Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tox file and fix warnings #334

Merged
merged 2 commits into from
Mar 29, 2022
Merged

Clean up tox file and fix warnings #334

merged 2 commits into from
Mar 29, 2022

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Mar 28, 2022

Pull Request doc

Purpose

Clean up tox.ini file and fix warnings raised by the test suite

What the code is doing

Convert set to list when using indexer in data frame to fix pandas' FutureWarning: Passing a set as an indexer is deprecated and will raise in a future version. Use a list instead

Testing

Run tox successfully

Remaining warnings come from owersimdata/input/helpers.py (l. 277) that has been fixed in Breakthrough-Energy/PowerSimData#609 and will propagate in PostREISE the next time we release PowerSimData

Where to look

  • Remove unnecessary environment variables in tox.ini file
  • Several modules where data frame are queried using set

Usage Example/Visuals

N/A

Time estimate

2 min

@rouille rouille self-assigned this Mar 28, 2022
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rouille rouille merged commit bdfc246 into develop Mar 29, 2022
@rouille rouille deleted the ben/tox branch March 29, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants