Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on ScenarioInfo objects #344

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Remove dependency on ScenarioInfo objects #344

merged 2 commits into from
Apr 29, 2022

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Apr 26, 2022

Pull Request doc

Purpose

Refactor the plot_generation_sim_vs_hist function to remove its dependency on a ScenarioInfo object

What the code is doing

  • Use a Scenario object in place of a ScenarioInfo object
  • Check type and value of the parameters
  • Write tests for the function

Testing

New tests

Where to look

In the postreise.plot.plot_sim_vs_hist module and the corresponding tests

Usage Example/Visuals

N/A

Time estimate

15min

@rouille rouille self-assigned this Apr 26, 2022
@rouille rouille changed the title Ben/si Remove dependency on ScenarioInfo objects Apr 29, 2022
Copy link
Contributor

@danielolsen danielolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests.

Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@rouille rouille merged commit cf3c53f into develop Apr 29, 2022
@rouille rouille deleted the ben/si branch April 29, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants