Add note and print statement to describe function's behavior #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BainanXia
reviewed
Aug 18, 2022
BainanXia
reviewed
Aug 18, 2022
jenhagg
approved these changes
Aug 18, 2022
BainanXia
approved these changes
Aug 18, 2022
rouille
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Add note and print statement in the
sum_generation_by_type_zonefunction. Closes issue #339.What the code is doing
Add a print statement if a condition is not met on parameter setting.
Testing
New unit test
Where to look
ifstatement in functionUsage Example/Visuals
N/A
Time estimate
5min