Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write test for plotting function plot_carbon_bar #371

Merged
merged 4 commits into from
Sep 12, 2022
Merged

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Sep 12, 2022

Pull Request doc

Purpose

Write test for plot_carbon_bar plotting function. Closes #370.

What the code is doing

Add a check to ensure that scenarios are in analyze state and use plot_show parameter across the entire function (a if statement was on show_plot)

Testing

New unit tests

Where to look

New test module and small changes in plotting function

Usage Example/Visuals

N/A

Time estimate

5min

@rouille rouille self-assigned this Sep 12, 2022
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@rouille rouille merged commit ea6a08f into develop Sep 12, 2022
@rouille rouille deleted the ben/carbon branch September 12, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write test for plot_carbon_bar
3 participants