Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate averaged congestion and save output file on server #89

Merged
merged 3 commits into from
Mar 26, 2020

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Mar 26, 2020

Purpose

A data frame enclosing the averaged CONGU and CONGL for each branch is written as a pickle file on the server In addition to the other usual simulation outputs.

What is the code doing

It calculates the averaged congestion via the calculate_averaged_congestion in the postreise.extract.extract_data module. The function is then used to save the returned data frame as pickle file.

Tests have been written in postreise.extract.tests.test_extract_data.

Time estimate

Should be fairly quick. A 24h test scenario could be created, ran and extracted to make sure the file is correctly saved.

Note

The procedure that download/load in the Scenario object this file still need to be implemented in PowerSimData.

@rouille rouille added new feature Feature that is currently in progress. congestion labels Mar 26, 2020
@danielolsen
Copy link
Contributor

To test this on a real Scenario, do we need to check out this branch locally or do we need to check it out on the server and then call scenario.state.extract_simulation_output() locally?

Copy link
Contributor

@danielolsen danielolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tests pass. Let's try it out!

@rouille
Copy link
Collaborator Author

rouille commented Mar 26, 2020

I forgot to populate the __all__ variable with the test. I commit, interactive and force push before merging.

@rouille rouille force-pushed the calculate_averaged_cong branch from d416066 to d9a1062 Compare March 26, 2020 21:54
@rouille rouille merged commit c3d7ff3 into develop Mar 26, 2020
@rouille rouille deleted the calculate_averaged_cong branch March 26, 2020 22:09
@kasparm kasparm restored the calculate_averaged_cong branch March 27, 2020 14:09
@ahurli ahurli mentioned this pull request Mar 16, 2021
@rouille rouille changed the title Calculate averaged congestion and save output corresponding file on server Calculate averaged congestion and save output file on server Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Feature that is currently in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants