Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analysis and plotting routines #9

Merged
merged 134 commits into from
Jan 16, 2019
Merged

Add analysis and plotting routines #9

merged 134 commits into from
Jan 16, 2019

Conversation

rouille
Copy link
Collaborator

@rouille rouille commented Jan 9, 2019

I have developed in the plot module. There, you will find the various analysis of the PG data I have produced. Check the README and the demo folder in plot. @mlamherr and @kasparm will need to include/clean their most recent developments on the congestion analysis.

kasparm and others added 30 commits September 13, 2018 13:09
@rouille rouille requested review from kasparm and mlamherr January 9, 2019 19:59
Copy link
Contributor

@kasparm kasparm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
Here some things to consider in order to improve your coding style for the future:

  • Try to use meaningful variable names as much as possible.
  • Try to avoid using the line-break sign as much as possible by introducing meaningful variable names and using these variable names to conduct the operation.
  • When doing line breaks, put the operation sign at the beginning of the line.

@@ -0,0 +1 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove return

@rouille rouille merged commit ab5e0e7 into develop Jan 16, 2019
@rouille rouille deleted the addAnalyzeAndPlot branch June 15, 2020 18:48
@ahurli ahurli mentioned this pull request Mar 16, 2021
@rouille rouille changed the title Add analyze and plot Add analysis and plotting routines Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants