-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: calculate interzone capacity #504
Conversation
I am wondering if the name of the function clearly communicate what is being done. I feel like discarding intra-zone branches should be reflected somehow in the name of the function. What about |
We have a git guide available here where you will find our commit message convention. You can reword your commit message to follow our convention with an interactive rebase. |
Finished all the script revision, would you please recheck to see if I shall make any modifications @BainanXia @jon-hagg @rouille |
4b4e90d
to
546bc44
Compare
546bc44
to
4c677c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean.
Pull Request doc
Purpose
The method calculates the aggregate transmission capacity (from + to) at zone level for each zone id. It is implemented in a similar way as "calculate_substation_capacity" method, but mapping for zone level.
What the code is doing
assign corresponding zone_id to the ends of each branch according to 'from_bus_id' and 'to'_bus_id'
filter branches: exclude those branches from and to the same zone
calculate the marginal transmission capacities by each unique 'from_zone_id" and by each unique 'to_zone_id' from filtered branches
calculate total transmission capacity for each zone by adding up 'from capacity' and 'to capacity' by each zone id
Value -> Values
grid->total transmission capacity by each zone for the grid
Testing
from powersimdata.design.transmission.substations import calculate_zone_capacity
from powersimdata.input.grid import Grid
grid = Grid("Western")
calculate_interzone_capacity(grid)