refactor: maximum LDV dwell period to 72 hours, finish charging efficiency implementation #314
Conversation
dmuldrew
added
the
transportation electrification
dmuldrew
changed the title
dmuldrew
changed the title
There was a problem hiding this comment.
This looks good. Changing the maximum dwell period for LDV to 72 hours to make it compatible with HDV makes sense, which I believe won't change the behavior of LDV because no LDV trips in the dataset has dwell period greater than 48 hours. Not sure whether it's worth the effort to make the dwell period a variable (maybe still a multiple of 24) so that if there are more HDV data coming in, corner cases will be handled automatically. Maybe that's overkill though.
prereise/gather/demanddata/transportation_electrification/immediate.py
Outdated
Show resolved
Hide resolved
| if power > 19.2: | ||
| charging_efficiency = 0.95 | ||
| else: | ||
| charging_efficiency = 0.9 |
There was a problem hiding this comment.
Not sure whether we should factor this out given it is used in both immediate charging and smart charging, also it would be great if references of these numbers (from assumptions or from existing studies?) can be added somewhere with the module.
There was a problem hiding this comment.
For now I’d leave it as is, as I’ve been using the diffs between the LDV and HDV immediate/smart charging files. There will be another PR that will just be moving code blocks around…
prereise/gather/demanddata/transportation_electrification/smart_charging.py
Outdated
Show resolved
Hide resolved
| model_year_profile[24:48] += ( | ||
| outputelectricload[48:72] | ||
| / (daily_vmt_total[day_iter] * 1000) | ||
| * emfacvmt | ||
| ) | ||
|
|
||
| else: | ||
| elif day_iter == len(input_day) - 2: | ||
| # MW | ||
| model_year_profile[day_iter * 24 : day_iter * 24 + 48] += ( | ||
| outputelectricload[:48] / (daily_vmt_total[day_iter] * 1000) * emfacvmt | ||
| ) | ||
| model_year_profile[:24] += ( | ||
| outputelectricload[48:72] | ||
| / (daily_vmt_total[day_iter] * 1000) | ||
| * emfacvmt | ||
| ) | ||
|
|
||
| else: | ||
| # MW | ||
| model_year_profile[day_iter * 24 : day_iter * 24 + 72] += ( |
There was a problem hiding this comment.
Not sure whether we can simplify the logic in a similar way above.
There was a problem hiding this comment.
Yeah, I’ve been thinking about what a generalized function for an arbitrary dwell window would look like, though it would likely be later…maybe also some type of detection of how big the dwell window should be.
Pull Request doc
Purpose
Reconcile LDV and HDV implementations into one.
What the code is doing
why_totodwell_locationLDV: add charging_efficiency condition #308
Testing
Automated tests
Time estimate
~20 min