refactor: LDV uses bev_vmt scaling; performance improvement; simplify model_year_profile updates #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BainanXia
reviewed
Oct 31, 2022
Comment on lines
+289
to
+296
| profile_window_indices = np.arange(day_iter * 24, day_iter * 24 + 72) % len( | ||
| model_year_profile | ||
| ) | ||
|
|
||
| else: | ||
| # MW | ||
| model_year_profile[day_iter * 24 : day_iter * 24 + 72] += ( | ||
| outputelectricload / (daily_vmt_total[day_iter] * 1000) * emfacvmt | ||
| ) | ||
| # MW | ||
| model_year_profile[profile_window_indices] += ( | ||
| outputelectricload / (daily_vmt_total[day_iter] * 1000) * bev_vmt | ||
| ) |
dmuldrew
added a commit
that referenced
this pull request
Nov 14, 2022
rouille
pushed a commit
that referenced
this pull request
Jan 11, 2023
rouille
pushed a commit
that referenced
this pull request
Jan 12, 2023
rouille
pushed a commit
that referenced
this pull request
Jan 19, 2023
rouille
pushed a commit
that referenced
this pull request
Jan 20, 2023
rouille
pushed a commit
that referenced
this pull request
Feb 1, 2023
rouille
pushed a commit
that referenced
this pull request
Feb 1, 2023
jenhagg
pushed a commit
that referenced
this pull request
Feb 23, 2023
jenhagg
pushed a commit
that referenced
this pull request
Feb 24, 2023
rouille
pushed a commit
that referenced
this pull request
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
This PR:
bev_vmtsimilar to HDV implementationmodel_year_profileby using modulo arithmeticWhat the code is doing
get_kwhmihelper functionindividualdataframeto simply
model_year_profileupdatesTesting
automated integration tests
Time estimate
~20min