Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dmuldrew/modify adjust bev #323

Merged
merged 11 commits into from
Nov 16, 2022
Merged

Dmuldrew/modify adjust bev #323

merged 11 commits into from
Nov 16, 2022

Conversation

dmuldrew
Copy link
Collaborator

@dmuldrew dmuldrew commented Nov 8, 2022 •
edited
Loading

Pull Request doc

Purpose

This PR:

  1. Combines LDV and HDV profile scaling implementations of immediate charging function adjust_bev
  2. Changes LDV trip window from 48 to 72 hours in line with MDV/HDV
  3. Starts adding unit tests to existing and new functions.
  4. Marks very slow PreREISE tests which download and save files as integration tests to speed up developer test feedback loop

Testing

automated integration and unit tests.

Time estimate

~20 min

@dmuldrew dmuldrew self-assigned this Nov 8, 2022
BainanXia
BainanXia reviewed Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Not sure whether we should rebase the branch onto develop so that time consuming tests are marked off by default in subsequent commits there.

prereise/gather/demanddata/transportation_electrification/immediate.py Outdated Show resolved Hide resolved
prereise/gather/demanddata/transportation_electrification/immediate.py Outdated Show resolved Hide resolved
prereise/gather/demanddata/transportation_electrification/immediate.py Outdated Show resolved Hide resolved
@dmuldrew dmuldrew force-pushed the transportation_electrification branch from 6b449de to 9dc4801 Compare November 14, 2022 23:47
@dmuldrew dmuldrew force-pushed the dmuldrew/modify_adjust_bev branch from 3641a83 to 8dd0285 Compare November 14, 2022 23:49
@dmuldrew dmuldrew requested a review from BainanXia November 15, 2022 23:35
BainanXia
BainanXia approved these changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@BainanXia BainanXia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@dmuldrew dmuldrew merged commit 6f44de3 into transportation_electrification Nov 16, 2022
@dmuldrew dmuldrew deleted the dmuldrew/modify_adjust_bev branch November 16, 2022 02:50
rouille pushed a commit that referenced this pull request Jan 11, 2023
@dmuldrew @rouille
refactor: modify immediate adjust_bev (#323)
5e8f2b9
rouille pushed a commit that referenced this pull request Jan 12, 2023
@dmuldrew @rouille
refactor: modify immediate adjust_bev (#323)
661e850
rouille pushed a commit that referenced this pull request Jan 19, 2023
@dmuldrew @rouille
refactor: modify immediate adjust_bev (#323)
414fc83
rouille pushed a commit that referenced this pull request Jan 20, 2023
@dmuldrew @rouille
refactor: modify immediate adjust_bev (#323)
87be61d
rouille pushed a commit that referenced this pull request Feb 1, 2023
@dmuldrew @rouille
refactor: modify immediate adjust_bev (#323)
a27b82e
rouille pushed a commit that referenced this pull request Feb 1, 2023
@dmuldrew @rouille
refactor: modify immediate adjust_bev (#323)
4f2e9f1
jenhagg pushed a commit that referenced this pull request Feb 23, 2023
@dmuldrew @jenhagg
refactor: modify immediate adjust_bev (#323)
ad1d423
jenhagg pushed a commit that referenced this pull request Feb 24, 2023
@dmuldrew @jenhagg
refactor: modify immediate adjust_bev (#323)
0eef481
rouille pushed a commit that referenced this pull request Feb 24, 2023
@dmuldrew @rouille
refactor: modify immediate adjust_bev (#323)
9a58cd7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BainanXia BainanXia BainanXia approved these changes

@rouille rouille Awaiting requested review from rouille

@danlivengood danlivengood Awaiting requested review from danlivengood

@jenhagg jenhagg Awaiting requested review from jenhagg

Assignees

@dmuldrew dmuldrew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmuldrew @BainanXia