Generate files for regional scaling factors for urban and rural areas #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlivengood
approved these changes
Feb 9, 2023
rouille
added a commit
that referenced
this pull request
Feb 24, 2023
Generate regional scaling factors files for urban and rural areas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request doc
Purpose
Remove outdated regional scaling factors files and generate new ones using code implemented in #333, #335, #337 and #342. Also the fuel efficiency file has been updated
What the code is doing
Use
if __name__ == '__main__'code block in thegenerate_scaling_factorsto be able to generate the regional scaling factors files for urban and rural areas for all 32 years (64 files) in the top level environment. Also update thegenerate_BEV_vehicle_profilesmodule to use state abbreviation in both urban and rural and update tests following changes in fuel efficiency file.Testing
Existing unit tests
Where to look
Very little code. Just using existing code in `if name == 'main' code block to write files on disk
Usage Example/Visuals
N/A
Time estimate
10min