Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use similar yaml across jobs, simplify naming #121

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

jenhagg
Copy link
Collaborator

@jenhagg jenhagg commented Apr 5, 2021

Minor improvements:

  • remove arch from matrix since I don't expect we'll use other values (e.g. x86)
  • leave out the os from the job name for now (we can add it back if we start running on more than just ubuntu)
  • fix the restore-keys list - my understanding is that setting the cache-name environment variable is used as an example in the docs to show cases like having multiple caches based on feature branches or some other variable. we aren't partitioning it this way (and I'm not super clear on when that would be useful anyway), so having a hard coded artifacts is sufficient.

Feel free to cherry pick or squash if it looks good.

Copy link
Contributor

@danielolsen danielolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you

@jenhagg jenhagg merged commit 6483dad into daniel/julia_test_ci Apr 5, 2021
@jenhagg jenhagg deleted the jon/daniel branch April 5, 2021 22:32
danielolsen added a commit that referenced this pull request Apr 5, 2021
* ci: add julia tests to test runs

* ci: use similar yaml across jobs, simplify naming (#121)

Co-authored-by: jon-hagg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants