Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few errors when parsing BSB USFM #282

Closed
trevorpfiz opened this issue Nov 23, 2024 · 1 comment · Fixed by #283
Closed

A few errors when parsing BSB USFM #282

trevorpfiz opened this issue Nov 23, 2024 · 1 comment · Fixed by #283

Comments

@trevorpfiz
Copy link

usfm-grammar>=3.0.0b16

I am using USFM files from the BSB from https://berean.bible/downloads.htm. These are the errors I am running into:

Errors in file data/bsb_usfm/38ZECBSB.usfm: [('At Point(row=553, column=0)', '\\d\n\\v 1 This is the burden of the word of the LORD concerning Israel.'), ('At Point(row=554, column=65)', '.')]
Errors in file data/bsb_usfm/35HABBSB.usfm: [('At Point(row=306, column=0)', '\\it For the choirmaster. With stringed instruments.\n\\it*'), ('At Point(row=306, column=23)', '.'), ('At Point(row=306, column=50)', '.')]
Errors in file data/bsb_usfm/19PSABSB.usfm: [('At Point(row=217, column=179)', 'A Psalm of David.'), ('At Point(row=217, column=195)', '.'), ('At Point(row=256, column=87)', 'of David, which he sang to the LORD concerning the words of Cush, a Benjamite.'), ('At Point(row=256, column=95)', ','), ('At Point(row=256, column=151)', ','), ('At Point(row=256, column=164)', '.'), ('At Point(row=322, column=145)', 'A Psalm of David.'), ('At Point(row=322, column=161)', '.'), ('At Point(row=543, column=152)', 'A Psalm of David.'), ('At Point(row=543, column=168)', '.'), ('At Point(row=673, column=120)', 'of David.'), ('At Point(row=673, column=128)', '.'), ('At Point(row=1904, column=159)', 'so that the king drove him away.'), ('At Point(row=1904, column=190)', '.'), ('At Point(row=2675, column=171)', 'of the sons of Korah.'), ('At Point(row=2675, column=191)', '.'), ('At Point(row=2773, column=204)', 'of the sons of Korah. A love song.'), ('At Point(row=2773, column=224)', '.'), ('At Point(row=2773, column=237)', '.'), ('At Point(row=2842, column=170)', 'A song.'), ('At Point(row=2842, column=176)', '.'), ('At Point(row=3221, column=171)', 'of David. After Doeg the Edomite went to Saul and told him, “David has gone to the house of Ahimelech.”'), ('At Point(row=3221, column=179)', '.'), ('At Point(row=3221, column=229)', ', “'), ('At Point(row=3221, column=274)', '.”'), ('At Point(row=3266, column=139)', 'A Maskil'), ('At Point(row=3266, column=286)', 'of David.'), ('At Point(row=3266, column=294)', '.'), ('At Point(row=3308, column=198)', 'of David. When the Ziphites went to Saul and said, “Is David not hiding among us?”'), ('At Point(row=3308, column=206)', '.'), ('At Point(row=3308, column=247)', ', “'), ('At Point(row=3308, column=280)', '?”'), ('At Point(row=3337, column=198)', 'of David.'), ('At Point(row=3337, column=206)', '.'), ('At Point(row=3435, column=180)', 'of David, when the Philistines seized him in Gath.'), ('At Point(row=3435, column=188)', ','), ('At Point(row=3435, column=229)', '.'), ('At Point(row=3493, column=172)', 'of David, when he fled from Saul into the cave.'), ('At Point(row=3493, column=180)', ','), ('At Point(row=3493, column=218)', '.'), ('At Point(row=3545, column=172)', 'of David.'), ('At Point(row=3545, column=180)', '.'), ('At Point(row=3594, column=172)', 'of David, when Saul sent men to watch David’s house in order to kill him.'), ('At Point(row=3594, column=180)', ','), ('At Point(row=3594, column=215)', '’'), ('At Point(row=3594, column=246)', '.'), ('At Point(row=3671, column=182)', 'of David for instruction. When he fought Aram-naharaim'), ('At Point(row=3671, column=206)', '.'), ('At Point(row=3671, column=227)', '-'), ('At Point(row=3671, column=410)', 'and Aram-zobah,'), ('At Point(row=3671, column=418)', '-'), ('At Point(row=3671, column=424)', ','), ('At Point(row=3671, column=486)', 'and Joab returned and struck down 12,000 Edomites in the Valley of Salt.'), ('At Point(row=3671, column=522)', ','), ('At Point(row=3671, column=557)', '.'), ('At Point(row=4668, column=150)', 'of Asaph.'), ('At Point(row=4668, column=158)', '.'), ('At Point(row=4919, column=150)', 'of Asaph.'), ('At Point(row=4919, column=158)', '.'), ('At Point(row=5311, column=145)', 'Of Asaph.'), ('At Point(row=5311, column=153)', '.'), ('At Point(row=5469, column=145)', 'A Psalm of the sons of Korah.'), ('At Point(row=5469, column=173)', '.'), ('At Point(row=5673, column=195)', 'A Maskil'), ('At Point(row=5673, column=342)', 'of Heman the Ezrahite.'), ('At Point(row=5673, column=363)', '.'), ('At Point(row=5742, column=150)', 'of Ethan the Ezrahite.'), ('At Point(row=5742, column=171)', '.'), ('At Point(row=9330, column=151)', 'of David, when he was in the cave. A prayer.'), ('At Point(row=9330, column=159)', ','), ('At Point(row=9330, column=184)', '.'), ('At Point(row=9330, column=194)', '.')]

What is the best way to handle this? Thanks!

@kavitharaju
Copy link
Collaborator

Thanks for reporting the issue.

Apart from the issue of missing paragraph markers after \b, there were 2 mode cases.

  1. Empty \d.
  2. Grammar not supporting footenotes in \d text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants