Add publicEndpoint to override resolved endpoint #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
reviewed
Oct 5, 2021
| @@ -78,6 +80,7 @@ var target = appResolver.getUrl(); | |||
| - `dist` - The directory containing the app files to serve. By default, the `dist` directory is used. | |||
| - `port` - The port to listen on. By default, port `3000` is used, which is the port that the LMS expects it on. | |||
| - `hostname` - The hostname (or IP) to listen on. By default, the hostname of the operating system is used. You should not need to change this. | |||
| - `publicEndpoint` - If provided overrides the protocol (http) hostname and port for endpoint resolution | |||
There was a problem hiding this comment.
Another option would be to make the new parameter protocol, so then you could use the existing port and hostname options and just set protocol = https. 🤷
There was a problem hiding this comment.
I tried that first, but I ran into trouble when trying to run the server. I also had to change the value of the port, which messed up this line:
app.listen(self._opts.port, function() {I only want to override the value which gets written into the appconfig.json file, i.e. for the loader endpoint. Having a single value to override makes it easier to customize the endpoint from the command line.
For example, in the smart-curriculum project, I'm doing this:
npm run build:config -- --publicEndpoint=https://arkt.ngrok.io
dlockhart
approved these changes
Oct 5, 2021
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to get everything using https. This PR makes it possible to serve the app resolver using ngrok