Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add publicEndpoint to override resolved endpoint #36

Closed
wants to merge 1 commit into from
Closed

Add publicEndpoint to override resolved endpoint #36

wants to merge 1 commit into from

Conversation

ktonon
Copy link
Contributor

@ktonon ktonon commented Oct 5, 2021

Trying to get everything using https. This PR makes it possible to serve the app resolver using ngrok

@ktonon ktonon requested a review from dbatiste as a code owner October 5, 2021 14:22
@ktonon
Copy link
Contributor Author

ktonon commented Oct 5, 2021

Do PRs need to be opened from the same fork? I don't have access to push to this origin

@dlockhart
Copy link
Member

@ktonon I've added the "everyone" team to this repo with Write permissions, so as long as you're a member you should be able to push now.

@ktonon
Copy link
Contributor Author

ktonon commented Oct 5, 2021

@ktonon I've added the "everyone" team to this repo with Write permissions, so as long as you're a member you should be able to push now.

Thank you. I opened #37

@ktonon ktonon closed this Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbatiste dbatiste Awaiting requested review from dbatiste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktonon @dlockhart