Replace dotnet runtime with SDK #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j3parker
approved these changes
Oct 23, 2019
|
@omsmith you cool with this? |
|
Thanks! |
omsmith
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResX compilation works by creating a
.csprojwith the resx file as an embedded resource. When compiled (using GenerateResourceTask), it will create the.resourcesfile that can then be embedded in the csharp lib/binary. To compile the csproj, we need the dotnet sdk.Downloading the dotnet SDK on windows (
dotnet-sdk-windows) takes around 86 seconds, and goes from ~45 MB (runtime + compiler) to ~110-150 MB (depending on OS).Related to #10 and #96