fix: US157225 - Ignore base element rects that throw off the position…

…ing because they have no width and/or height (#162)
BrightspaceUI · Sep 5, 2023 · 22ca908 · 22ca908
1 parent 17f38ab
commit 22ca908
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/browser/vdiff.js b/src/browser/vdiff.js
@@ -32,12 +32,14 @@ function findLargestRect(elems) {
 		const targets = findTargets(elem);
 		targets.forEach(target => {
 			const targetRect = target.getBoundingClientRect();
-			largestRect = {
-				left: Math.floor(Math.min(largestRect.left, targetRect.left)),
-				top: Math.floor(Math.min(largestRect.top, targetRect.top)),
-				right: Math.ceil(Math.max(largestRect.right, targetRect.right)),
-				bottom: Math.ceil(Math.max(largestRect.bottom, targetRect.bottom))
-			};
+			if (targetRect.width !== 0 && targetRect.height !== 0) {
+				largestRect = {
+					left: Math.floor(Math.min(largestRect.left, targetRect.left)),
+					top: Math.floor(Math.min(largestRect.top, targetRect.top)),
+					right: Math.ceil(Math.max(largestRect.right, targetRect.right)),
+					bottom: Math.ceil(Math.max(largestRect.bottom, targetRect.bottom))
+				};
+			}
 		});
 	});