Replace unsafe characters in screenshot file names #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearfriend
changed the title
dlockhart
approved these changes
Mar 11, 2024
Yeah, hopefully since no one has brought this up it won't affect anyone yet |
|
🎉 This PR is included in version 1.13.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows has a set a characters that are not allowed in file paths, so we should remove them before naming the screenshot files. Linux doesn't allow
/but that's already included.This approach replaces each character with a
-, which leaves a small possibility of conflicts, but I think the suggestion would just be to be more specific in that case.