Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run notebooks on coast repo #631

Merged
merged 10 commits into from
Nov 6, 2023
Merged

run notebooks on coast repo #631

merged 10 commits into from
Nov 6, 2023

Conversation

thogar-computer
Copy link
Member

@thogar-computer thogar-computer commented Oct 31, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been reviewed and added/updated if needed (for bug fixes/features)

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The PO would like the notebooks to be run within the GitHub workflow

Issue URL: #552

What is the new behavior?

All the notebook GitHub actions have been copied over and slimed down to only run the notebooks (not moving the markdown and Images)

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing (pip install . && pytest unit_testing/unit_test.py -s)
  • Extended the README/documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Does this introduce a breaking change?

  • Yes
  • No

Other information

@thogar-computer
Copy link
Member Author

We spilt out the notebook runner/converts in the coast-site repo so I have keep it the same here.... not sure if that'll mean a quicker run / better logging or if it just means a lot of repeated (wasted) compute...

@thogar-computer thogar-computer merged commit 78a63af into develop Nov 6, 2023
@thogar-computer thogar-computer deleted the feature/552_notebooks branch November 6, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants