This repository has been archived by the owner on Oct 13, 2018. It is now read-only.
Fix Network Throttle TypeError with HTTPS (fix #43) #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the CI failed, but please verify that the file in question does, in fact, not contain the method. |
|
Thanks! I will get to this asap :) |
shakyShane
added a commit
to BrowserSync/browser-sync
that referenced
this pull request
Jan 30, 2017
|
Released at |
|
Thanks! You have been invited to the Browsersync org (which means you'll full write access to all repos) Please continue to submit PRs for code changes & be sure to review the guidelines. https://github.com/BrowserSync/browser-sync/blob/master/CONTRIBUTING.md#-submitting-a-pull-request Any questions, just ask :) |
This was referenced Jan 30, 2017
This was referenced Feb 13, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getKeyAndCertmethod does not exist, so calling it causes a TypeError (see #43). This PR fixes that by callinggetHttpsOptionsinstead, which results in the correct key and cert to be returned.