Skip to content

Commit

Permalink
feat(https): remove type constraint on https option - fixes #1211
Browse files Browse the repository at this point in the history
  • Loading branch information
@shakyShane
shakyShane committed Sep 29, 2016
1 parent 24dbf3e commit 27a08c2
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/cli/opts.start.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"desc": "Specify the start path for the opened browser"
},
"https": {
"type": "boolean",
"desc": "Enable SSL for local development"
},
"directory": {
Expand Down

2 comments on commit 27a08c2

@OliverJAsh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to specify the type so it appears in --help etc?

@shakyShane
Copy link
Contributor Author

@shakyShane shakyShane commented on 27a08c2 Sep 29, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no because currently this is mis-leading as it can be a bool/pjo

this is a limitation of 'yarg' tbh and can be solved with the docs I think :)

Please sign in to comment.