fix(102): Clear accumulated message between HL7 messages/requests. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# [2.5.0](Bugs5382/node-hl7-server@v2.4.1...v2.5.0) (2024-08-29) ### Features * **Bugs5382#100:** added AE support ([20f33c3](Bugs5382@20f33c3)), closes [Bugs5382#100](Bugs5382#100) * **Bugs5382#100:** support ae type in send response ([Bugs5382#101](Bugs5382#101)) ([5e09595](Bugs5382@5e09595)), closes [Bugs5382#100](Bugs5382#100) * develop ([Bugs5382#104](Bugs5382#104)) ([b38334b](Bugs5382@b38334b))
BREAKING CHANGE: MSH Override Changes
BREAKING CHANGE: MSH Override Changes
# [3.0.0-beta.1](Bugs5382/node-hl7-server@v2.5.0-beta.1...v3.0.0-beta.1) (2024-09-21) * 103 feat allow overriding response msh content ([Bugs5382#107](Bugs5382#107)) ([ba7ec92](Bugs5382@ba7ec92)) ### Features * Allow overriding response MSH content [Bugs5382#103](Bugs5382#103) ([b208429](Bugs5382@b208429)) * Allow overriding response MSH content [Bugs5382#103](Bugs5382#103) ([Bugs5382#106](Bugs5382#106)) ([1dcef70](Bugs5382@1dcef70)) ### BREAKING CHANGES * MSH Override Changes * MSH Override Changes
# [3.0.0-beta.2](Bugs5382/node-hl7-server@v3.0.0-beta.1...v3.0.0-beta.2) (2024-09-21) ### Features * develop ([Bugs5382#104](Bugs5382#104)) ([b38334b](Bugs5382@b38334b))
# [3.0.0](Bugs5382/node-hl7-server@v2.5.0...v3.0.0) (2024-09-21) * 103 feat allow overriding response msh content ([Bugs5382#107](Bugs5382#107)) ([ba7ec92](Bugs5382@ba7ec92)) ### Features * 3.0.0 ([Bugs5382#108](Bugs5382#108)) ([1252e23](Bugs5382@1252e23)) * Allow overriding response MSH content [Bugs5382#103](Bugs5382#103) ([b208429](Bugs5382@b208429)) * Allow overriding response MSH content [Bugs5382#103](Bugs5382#103) ([Bugs5382#106](Bugs5382#106)) ([1dcef70](Bugs5382@1dcef70)) ### BREAKING CHANGES * MSH Override Changes * MSH Override Changes
accumulator. Port overridew for tests.
alwhiting
changed the title
|
If you have a different PDF test that this doesn't pass please share it I'm happy to try and do some more work! |
|
@alwhiting I am checking this out right now. |
Bugs5382
changed the base branch from
main
to
102-fix-loadedmessage-is-not-cleared-after-messages-handled
Bugs5382
merged commit ae7d002
into
Bugs5382:102-fix-loadedmessage-is-not-cleared-after-messages-handled
1 check passed
|
🎉 This PR is included in version 3.0.1-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this addresses #102
I see there was some problem with PDF file tests but so far all tests pass for me and this has been working in my load testing.
It creates a copy of the
loadedMessagsebuffer/accumulator to avoid racy behavior when calling the handlers incase they are async. Then as only the copy is needed for handling it immediately clears the accumulator. The copy will increase memory usage a bit but it's a safe option.Also added the ability to override port for tests since I had stuff running on :3000 and it was easier than stopping it.
Usage:
TEST_PORT=19999 npm test(or just omitting it defaults to 3000 as before)Search terms
Questioner
Please check the type of change your PR introduces:
Other things: