[BUG] Clicking in the table of contents doesn't update the article view sometimes

[ThomasFrans]

Describe the bug
When clicking on some parts of the table of contents on the right, the view sometimes doesn't go to that section. I don't see when it works and when it doesn't, but it seems to be pretty random.

To Reproduce

1. Open a page (I was testing with the Linux Kernel page)
2. Click on the table of contents
3. It doesn't scroll in the article view sometimes

Expected behavior
The view should follow the clicked section on the table of contents.

Additional context
Latest version, installed with Cargo (There should probably be a section in the template for this information :))

Checklist

• checked other issues for the same bug
• read CONTRIBUTING.md

[Builditluc]

Hey @ThomasFrans!
Thank you for your bug report!

Upon further testing (I also used the Linux Kernel page) it seems that if the first item in the list is selected if you are at the beginning of the article, you can select every other item and it jumps to that section in the article.

Selecting an item that is higher than the currently selected item also works. The thing that is strange here is that the only thing that doesn't work is selecting an item that is below the current item when you aren't at the top of the page.

I'll work on fixing this as soon as possible

[Builditluc]

(There should probably be a section in the template for this information :))

Yes, I honestly don't know why it's not there yet.
Thanks!

[Builditluc]

I've uploaded a patch that should fix the issue. Until the next version is released, you can use it by installing wiki-tui from the git repo.

cargo install --git https://github.com/builditluc/wiki-tui

Does this patch fix the issue for you?

[ThomasFrans]

I don't know if this is an issue on my pc but now it causes crashes and the program behaves pretty weird. When I use arrows to select an item after entering a search term, the program crashes, and when clicking an item in the table of contents, it crashes as well.

[Builditluc]

Hm, that's weird.
What does the error message in the crash report say?

[ThomasFrans]

Where do I find the crash report when I installed through Cargo?

[Builditluc]

When wiki-tui crashes, it creates a crash report in the current working directory

[ThomasFrans]

I found this in my home folder (from where I ran it). It doesn't show any errors...

[Builditluc]

That's weird. Maybe the problem is with cargo installing it from the git repository (I've never tried cargo --git before).
Can you maybe try building it locally?

[ThomasFrans]

Same thing when I build it locally, it also crashes with no errors in the log...

[ThomasFrans]

I have the previous version on my system as I made a AUR package for it (which is in the aur now 😉) and that one works. So it must be something in the new fix...

[Builditluc]

Hm that's weird because I cannot reproduce this behaviour

[ThomasFrans]

Would a video showing the problem help?

[Builditluc]

Great idea but without the crash report (which wiki-tui somehow doesn't generate? very weird) it wouldn't be much of a help

[Builditluc]

I'm guessing it has something to do with the mouse support (that's the only change I made that affects the event system, aka what happens when you press a key).
I removed the mouse support commit from the development branch of this issue (39-bug-clicking-in-the-table-of-contents-doesnt-update-the-article-view-sometimes). Can you please checkout this branch locally and check if that fixed it?

[ThomasFrans]

Not even that one is working. It also crashes and shows the same behavior as the new commit. I don't know what is causing this, cause the 0.4.8 release is working flawlessly.

[ThomasFrans]

Just tried the 0.4.8 release with a local build (cargo run), and it works, even without installing. I thought maybe it was a problem with the fact that it wasn't installed, but expected to be installed. There must be a commit between that one (d5fabf2) and the current one that causes this...

[Builditluc]

Okay, so I've just looked at the diff and the only logical conclusion I've come to is that the keybinding thing (a feature I've added that lets you remap certain actions) is broken on some machines

[Builditluc]

I'll look further into this and try to reproduce the bug (because on my machine it works somehow), then I'll work on a fix

[ThomasFrans]

I just took a quick glance at the code and this looks a bit weird. It defines the Vim keybindings, but there is no binding for down. Maybe I'm reading it wrong, but there is no 'j' defined. Also only the 'Down' action seems to crash the program.

[ThomasFrans]

Jup, that fixes it!

[Builditluc]

Thanks to you I know what happens, with the keybindings thing you can remap the keys via the configuration file. The problem here is: If you don't remap the key it creates an infinite event loop and this is why it throws a "stack overflow" error

[Builditluc]

And because only the "down" action uses this (I forgot the other ones) only down crashes the program

[Builditluc]

Until I've fixed this you can "hack" your way around this by remapping the down key in your configuration file:

[keybindings]
down.key = "j"

[Builditluc]

I'll create a new issue for the keybinding error

[Builditluc]

I've linked the PR with the patch to this issue so it'll be closed once merged.

Thank you for your bug report and help in finding the issue!