Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the wiki::search module #224

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Rewrite the wiki::search module #224

merged 4 commits into from
Aug 17, 2023

Conversation

Builditluc
Copy link
Owner

Linked to: #217 #216

Changes made:

- refactor: make search attributes public
- refactor: add SearchContinue data struct
- refactor: remove dependency of Search in on_article_submit
- docs: add wiki::search documentation

Closes #217

@Builditluc Builditluc linked an issue Aug 17, 2023 that may be closed by this pull request
Rewrite the wiki::search module #217
Closed
4 tasks
@Builditluc Builditluc added state: approved This issue or pull request was approved and can be worked on type: refactor Changes to the style and structure of the codebase or project labels Aug 17, 2023
@Builditluc Builditluc self-assigned this Aug 17, 2023
@Builditluc Builditluc merged commit 9b8886d into main Aug 17, 2023
@Builditluc Builditluc deleted the rewrite-search-mod branch August 17, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Builditluc Builditluc

Labels
state: approved This issue or pull request was approved and can be worked on type: refactor Changes to the style and structure of the codebase or project
Projects
wiki-tui: Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rewrite the wiki::search module
1 participant
@Builditluc