Add #[inline] to allow for cross-crate inlining #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
#[inline]
, the function definition is not exported for inlining by other crates. For the byte order conversion functions, inlining can make a great difference in code quality.For example, trying this small test crate:
The result without
#[inline]
in thebyteorder
crate:The result after adding
#[inline]
to thebyteorder
crate:As you can see,
LittleEndian::read_u64(...)
on a little-endian processor, when the compiler can determine statically that the buffer is large enough, can be inlined into a single "load" instruction.The same should apply to all the functions I marked as
#[inline]
in this pull request.