Fix a few issues in the hyperlink docs #2612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BurntSushi
reviewed
Sep 25, 2023
crates/core/app.rs
Outdated
| @@ -1536,7 +1536,7 @@ put into a URI. Note that a path is guaranteed to start with a */*. | |||
|
|
|||
| *{host}*: Optional. This is replaced with your system's hostname. On Unix, | |||
| this corresponds to calling *gethostname*. On Windows, this corresponds to | |||
| calling *GetComputerNameExW* to fetch the system's \"physical DNS hostname.\" | |||
| calling *GetComputerNameExW* to fetch the system's \"physical DNS hostname\". | |||
There was a problem hiding this comment.
I had it this was when I first wrote it, but it looked wrong to me (I'm in the US). Can you change it back please? And in the place above too.
There was a problem hiding this comment.
Oh, I didn't know this is the way it's written in the US. I reverted it.
There was a problem hiding this comment.
Yeah it's annoying. I sometimes put the period outside the quotes anyway.
ltrzesniewski
force-pushed
the
hyperlink-docs
branch
from
836b489 to
3d8c84e
Compare
BurntSushi
added
the
rollup
BurntSushi
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for merging the hyperlinks feature and improving the implementation!
I read your changes and found a few minor issues in the docs, which I've fixed here.
FYI I tested your version on Windows and WSL, and everything works fine there. 👍