-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net.IP values in file causes error #39
Comments
mmm, I think it used to work, but i'm not 100% sure. |
Could you please |
Could you please provide an example TOML document tgat reproduces the issue? My suspicion is that your IP address is not in double quotes as a string. |
Correct, it is not in double quotes - they are printed without by
To get me and other users started, I get boot2docker to print the current config out - and I found this because I piped that output into the profile file that we then read using toml I was going to send you a patch, but then I found some other things i needed to look into :/ |
This encoder is killing me. I'm taking a look at it now. |
I'm not sure that is the root issue :/ I've given you a PR to show the problem, but what I'm thinking is that toml should either not output something if it doesn't know how to deal with it (so that it can always Decode its Encoding) or something so hyper magical its scary. |
The encoding should really work the same way that the standard library encoders do. Its case analysis over all the core types in Go. But there's some special magic involved when a type satisfies one of the encoding interfaces. net.IP falls in that category. If the encoder is outputting bare IP addresses, then that means it's probably handling the encoding interfaces incorrectly. It should actually be a simple fix, but I'm overreacting a bit because the encoder has been a source of many bugs recently. |
awesome, merci :) |
Added @SvenDowideit's round trip test which reproduces the bug in BurntSushi#39. Close BurntSushi#40.
…derscores Accept underscores in integers
config error: Near line 14, key '': Near line 14: Expected a top-level item to end with a new line, comment or EOF, but got '.' instead.
related to the setInt issue
sorry, I didn't look hard at the time :/
The text was updated successfully, but these errors were encountered: