Support maps with interface{} type keys #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @BurntSushi - is it possible to merge this? Or is there anything else you need me to do to get this merged? |
hairyhenderson
force-pushed
the
support-map-interface-keys
branch
from
44f109f to
d1df168
Compare
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
support-map-interface-keys
branch
from
d1df168 to
2a4f3b6
Compare
|
Closing this per the comment on #178 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #178
This allows
map[interface{}]interface{}to be encoded, if each and every key can be coerced to be astring. See #178 for more explanation.Signed-off-by: Dave Henderson [email protected]