Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 Fix socket missing when converting from .ipynb #143

Merged
merged 2 commits into from
Jan 10, 2022
Merged

🪲 Fix socket missing when converting from .ipynb #143

merged 2 commits into from
Jan 10, 2022

Conversation

FabienRoger
Copy link
Contributor

Fixes #139

MathisFederico
MathisFederico previously approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a test for this issue ?
At least add a screenshot of the solved issue in discussion for traceability !

@FabienRoger
Copy link
Contributor Author

How it is supposed to be (after the bug correction):
image

MathisFederico
MathisFederico approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect ! Thanks a lot !

@MathisFederico MathisFederico changed the title 🪲 Fix socket missing bug 🪲 Fix socket missing when converting from .ipynb Jan 10, 2022
@MathisFederico MathisFederico merged commit 8e49417 into dev Jan 10, 2022
@MathisFederico MathisFederico deleted the bug/socket-from-ipynb-missing branch January 10, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisFederico MathisFederico MathisFederico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No sockets on first and last blocks when loading from ipynb
2 participants
@FabienRoger @MathisFederico