Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 Deal with ipynb of different format #221

Merged
merged 2 commits into from
Jan 15, 2022
Merged

🪲 Deal with ipynb of different format #221

merged 2 commits into from
Jan 15, 2022

Conversation

FabienRoger
Copy link
Contributor

Fixes #213

MathisFederico
MathisFederico requested changes Jan 14, 2022
View reviewed changes
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an integration test to ensure this .ipynb type will be covered.
Maybe we should have a test for each common platform (vscode, colab, jupyterlab, kaggle, ...)

pyflow/scene/from_ipynb_conversion.py Outdated Show resolved Hide resolved
pyflow/scene/from_ipynb_conversion.py Outdated Show resolved Hide resolved
MathisFederico
MathisFederico approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix !
If this appears again for an other format reason, we will need tests !

@MathisFederico MathisFederico merged commit 7758498 into dev Jan 15, 2022
@MathisFederico MathisFederico deleted the bugfix/longblocks branch January 15, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisFederico MathisFederico MathisFederico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some converted notebooks have abnormally long code blocks
2 participants
@FabienRoger @MathisFederico