Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎉:art: Switch to vertical layout #227

Merged
merged 6 commits into from
Jan 22, 2022
Merged

🎉:art: Switch to vertical layout #227

merged 6 commits into from
Jan 22, 2022

Conversation

FabienRoger
Copy link
Contributor

Fixes #186

@FabienRoger
Copy link
Contributor Author

FabienRoger commented Jan 21, 2022 •
edited by MathisFederico
Loading

See screenshots in issue

MathisFederico
MathisFederico requested changes Jan 21, 2022
View reviewed changes
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice !
A few changes and we are good to go !

pyflow/scene/from_ipynb_conversion.py Outdated Show resolved Hide resolved
pyflow/scene/from_ipynb_conversion.py Show resolved Hide resolved
pyflow/scene/from_ipynb_conversion.py Show resolved Hide resolved
@MathisFederico
Copy link
Member

Also other .ipyg examples ant tests assets should be updated accordingly

MathisFederico
MathisFederico approved these changes Jan 22, 2022
View reviewed changes
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice thank you !

@MathisFederico MathisFederico changed the title Make the flow vertical 🎉 Switch to vertical layout Jan 22, 2022
@MathisFederico MathisFederico changed the title 🎉 Switch to vertical layout 🎉:art: Switch to vertical layout Jan 22, 2022
@MathisFederico MathisFederico merged commit d26f430 into dev Jan 22, 2022
@MathisFederico MathisFederico deleted the feature/vertical-flow branch January 22, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathisFederico MathisFederico MathisFederico approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vertical structure
2 participants
@FabienRoger @MathisFederico