Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Create a distinct clipboard for blocks #229

Merged
merged 3 commits into from
Jan 22, 2022
Merged

Conversation

FabienRoger
Copy link
Contributor

Fixes #198

Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this can crash the application if not handle properly, it clearly needs his own integration tests.

Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes, but it does seem to work fine !
Although tests are required for this critical behavior.

"""Cut the selected items and put them into clipboard."""
self.scene = scene
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attribute scene should be set in the init function, or not be an attribute at all.

pyflow/scene/clipboard.py Outdated Show resolved Hide resolved
pyflow/scene/clipboard.py Outdated Show resolved Hide resolved
tests/unit/scene/test_clipboard.py Show resolved Hide resolved
Copy link
Member

@MathisFederico MathisFederico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A welcome fix !
Thank you !

@FabienRoger FabienRoger merged commit d422b47 into dev Jan 22, 2022
@MathisFederico MathisFederico changed the title Create a disinct clipboard for blocks 🎉 Create a distinct clipboard for blocks Jan 22, 2022
@MathisFederico MathisFederico deleted the bugfix/paste-block branch January 22, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copying a block in an editor will paste its JSON
2 participants