🪲 removes kernel timeout #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: Removing a timeout fixes the bug where outputs are shown on the wrong blocks
At the beginning of the project, I put a 1-hour timeout on waiting for a message from the kernel.
It worked quite well until one day where we had an isolated incident that I could not reproduce (it was only happening in one virtual environement) where Pyflow was waiting 1 hour for a message that was not coming. I then switched the timeout to two seconds.
But now, on some long ipyg, this timeout creates issues where the output of one block is shown on another.
I have decided to remove this timeout for now until this creates issues in the beta.