Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes for the docs: typos, formatting, links, duplications #74

Merged
merged 5 commits into from
Dec 18, 2024
Merged

Small fixes for the docs: typos, formatting, links, duplications #74

merged 5 commits into from
Dec 18, 2024

Conversation

mikapfl
Copy link
Contributor

@mikapfl mikapfl commented Dec 18, 2024 •
edited by github-actions bot
Loading

While doing the JOSS review, I noticed a few minor issues in the (otherwise very helpful) docs.

The ipython dependency for the docs is necessary to get proper syntax highlighting, otherwise sphinx complains with a warning.

📚 Documentation preview 📚: https://emiproc--74.org.readthedocs.build/en/74/

lionel42
lionel42 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@lionel42 lionel42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the small changes, looks good to me.

@lionel42 lionel42 merged commit 159ac77 into C2SM-RCM:master Dec 18, 2024
3 checks passed
@mikapfl mikapfl deleted the docs branch January 8, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionel42 lionel42 lionel42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikapfl @lionel42