Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible .jfif file format support? #163

Closed
Bluecolty opened this issue Oct 4, 2024 · 7 comments · Fixed by #167
Closed

Possible .jfif file format support? #163

Bluecolty opened this issue Oct 4, 2024 · 7 comments · Fixed by #167
Labels
enhancement New feature or request

Comments

@Bluecolty
Copy link

Hey, just started running ConvertX on my unraid machine and it works great! This is such a wonderful container you've made, it just works.

I know you've got a ton of stuff on your TODO list, but if you have the time, support for the .jfif format would be really awesome. It's a somewhat common format when you download images from the web. Being able to quickly upload and convert a .jfif image to something else would be wonderful.

I just tried it a few minutes ago and it uploads fine, but when I search for conversions, none appear. It looks like its a matter of just changing the file extension from .jfif to .jpg

Let me know if you need anything else from me, this is my first time opening an issue on GitHub.

@C4illin
Copy link
Owner

C4illin commented Oct 4, 2024

None of the available converters seem to make correct jfif images.

Vips is the only one that supports jfif out of the box, but it seems to be a "fake" format libvips/libvips#3775

So either I treat it as a jpeg or allow vips to read and save fake jfif images. I think I prefer the vips approach since jpeg isn't fully jfif if I understand everything correctly. What do you think?

@Bluecolty
Copy link
Author

Oh just to clarify so we're on the same page, this is for converting a .jfif image to something else, such as a jpeg.

So maybe, just treating it as a jpeg would be an option? It reads a .jfif as a jpeg, tells the various converters its a .jpeg, then gives the options to convert it to something else. Maybe that could be an implementation with vips so it can read the file and then convert accordingly.

@C4illin
Copy link
Owner

C4illin commented Oct 4, 2024

Well I mean that jfif is an extension to the jpeg standard, which isn't supported. But if you treat it like an jpeg it is supported, which vips by default does, but not the other programs.

C4illin added a commit that referenced this issue Oct 4, 2024
issue #163
C4illin added a commit that referenced this issue Oct 4, 2024
@C4illin C4illin added the enhancement New feature or request label Oct 4, 2024
@Aymendje
Copy link
Contributor

Aymendje commented Oct 5, 2024

jfif is just a subset of compressed jpeg, and should be supported by any converter.
It is usually safe to rename "jfif" to "jpeg" (see https://superuser.com/questions/1657480/is-it-safe-to-simply-rename-a-jfif-file-to-jpg)

We could simply add ".jfif" to any of the ".jpeg" converters (I tried on ffmpeg and imageMagick and it works without any issues)

C4illin added a commit that referenced this issue Oct 5, 2024
@C4illin
Copy link
Owner

C4illin commented Oct 5, 2024

Yeah probably makes more sense to just treat it as a jpeg then

@Bluecolty
Copy link
Author

Thanks so much for adding it! Apologies for not responding sooner, I missed the email notification. I really appreciate you taking the time to look at it.

@C4illin
Copy link
Owner

C4illin commented Oct 7, 2024

No worries, thanks for reporting it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants