Add initialisation routine for offline drivers #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanBryan51
force-pushed
the
425-offline-driver-initialisation-refactor
branch
from
e410bcc to
529e83c
Compare
micaeljtoliveira
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
@SeanBryan51 Overall looks good!
Most of my comments are quite general and, at this point, they are all optional.
micaeljtoliveira
requested changes
Oct 31, 2024
micaeljtoliveira
approved these changes
Nov 1, 2024
ccarouge
approved these changes
Nov 6, 2024
SeanBryan51
force-pushed
the
425-offline-driver-initialisation-refactor
branch
from
337142c to
0af4a0f
Compare
Copyright statement generated via: ``` head -n 3 License.md | fold -s -w 88 | awk NF | sed '/^#[ ]*/s/^#[ ]*//g;s/^/! /' ``` See [here][copyright-header] for more details [copyright-header]: https://cable.readthedocs.io/en/latest/developer_guide/other_resources/coding_standards/#8-copyright-header
SeanBryan51
force-pushed
the
425-offline-driver-initialisation-refactor
branch
from
0af4a0f to
f02dc3b
Compare
|
Testing with PBS log file: Benchcab version:
|
6 tasks
SeanBryan51
added a commit
that referenced
this pull request
Nov 25, 2024
This change further consolidates the initialisation logic within the offline drivers to remove code duplication and improve code clarity across each of the drivers (see #425, #440 and #469). As part of the refactoring changes, new optional namelist options (`filename%new_sumbal` and `filename%trunk_sumbal`) are introduced to replace hard coded filenames and optional namelist option `CASAonly` is restored for consistency with the documentation. ## Type of change - [x] Code refactor - [x] New feature - [x] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [x] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--472.org.readthedocs.build/en/472/ <!-- readthedocs-preview cable end -->
5 tasks
SeanBryan51
added a commit
that referenced
this pull request
Nov 29, 2024
…#498) This change further consolidates the initialisation logic within the offline drivers (in particular logic related to `cable_user%MetType`) to remove code duplication and improve code clarity across each of the drivers (see #425, #440, #469 and #472). As part of the refactoring changes, the `cable_user%MetType = 'gpgs'` namelist parameter is deprecated as it is equivalent to setting `cable_user%MetType = 'gswp'` and `leaps = .TRUE.`. ## Type of change - [x] Code refactor - [x] New or updated documentation ## Checklist - [x] The new content is accessible and located in the appropriate section. - [x] I have checked that links are valid and point to the intended content. - [x] I have checked my code/text and corrected any misspellings <!-- readthedocs-preview cable start --> ---- 📚 Documentation preview 📚: https://cable--498.org.readthedocs.build/en/498/ <!-- readthedocs-preview cable end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst looking into merging the MPI master and worker drivers (#358), @micaeljtoliveira and I have identified that the model initialisation logic is duplicated across all drivers (serial and MPI master/worker). This change adds a preliminary initialisation routine to remove code duplication and improve code clarity across each of the drivers. The remaining initialisation code in the offline drivers will be moved to this routine in later pull requests to clean up the drivers further.
Checklist
📚 Documentation preview 📚: https://cable--440.org.readthedocs.build/en/440/