Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/number string #1288

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Refactor/number string #1288

merged 5 commits into from
Oct 4, 2023

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Oct 2, 2023 •
edited
Loading

DEVELOP

  • BalanceSection
  • CryptoCard
  • DepositHistoryModal
  • DepositModal
  • HistoryPositionItem
  • InterestSection
  • OpenPositionItem
  • PositionUpdatedModal
  • ReceiptItem
  • Statistics
  • TradeStatistics
  • TradeTab
  • TradingHeader
  • UpdateFormModal
  • UserOverview
  • UserPersonalRanking
  • WithdrawalHistoryModal
  • WithdrawalModal

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

arealclimber and others added 5 commits October 2, 2023 12:16
@arealclimber
fix: 🐛 sharing CFD couldn't display the outcome correctly
7cc9a50 
✅ Closes: #1204
@arealclimber
Squashed commit of the following:
9b67dd0 
commit 0c5803c
Merge: 729a58b 9d8b0e4
Author: Luphia Chang <[email protected]>
Date:   Mon Oct 2 11:16:49 2023 +0800

    Merge pull request #1272 from CAFECA-IO/feature/news-0928

    feat: 🎸 9/28 news

commit 9d8b0e4
Merge: 295aaca 729a58b
Author: Luphia Chang <[email protected]>
Date:   Mon Oct 2 11:16:42 2023 +0800

    Merge branch 'develop' into feature/news-0928

commit 295aaca
Author: RexBearIU <[email protected]>
Date:   Thu Sep 28 16:41:54 2023 +0800

    feat: 🎸 9/28 news

commit 921809b
Author: RexBearIU <[email protected]>
Date:   Thu Sep 28 12:43:46 2023 +0800

    feat: finish news content
@arealclimber
Merge branch 'develop' into fix/share-img
bde2b3f
@arealclimber
refactor: 💡 wrap number/string with func to be orderly
fce1da8
@arealclimber
refactor: 💡 wrap all number/string in numberFormatted
ac37e40 
✅ Closes: #1151
@vercel
Copy link

vercel bot commented Oct 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 9:33am

@arealclimber arealclimber linked an issue Oct 2, 2023 that may be closed by this pull request
檢查 number => string 轉換 #1151
Closed
@arealclimber arealclimber self-assigned this Oct 3, 2023
Luphia
Luphia approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 05421b3 into develop Oct 4, 2023
@Luphia Luphia deleted the refactor/number-string branch October 4, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

@Julian0701 Julian0701 Awaiting requested review from Julian0701

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

檢查 number => string 轉換
2 participants
@arealclimber @Luphia