Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/customized dir news #1315

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Hotfix/customized dir news #1315

merged 3 commits into from
Oct 6, 2023

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Oct 6, 2023 •
edited
Loading

DEVELOP

  • src/pages/news/[newsId].tsx

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

@vercel
Copy link

vercel bot commented Oct 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 9:57am

@arealclimber arealclimber self-assigned this Oct 6, 2023
@arealclimber arealclimber linked an issue Oct 6, 2023 that may be closed by this pull request
[BUG] couldn't access to news page #1314
Closed
Luphia
Luphia approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 1665772 into feature/news-1006 Oct 6, 2023
@Luphia Luphia deleted the hotfix/customized-dir-news branch October 6, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

@Julian0701 Julian0701 Awaiting requested review from Julian0701

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] couldn't access to news page
2 participants
@arealclimber @Luphia