Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 🎸 toggle of displaying line graph of open positions, modify the string of toggle of displaying trading view #1342

Merged
merged 2 commits into from
Oct 17, 2023
Merged

feat: 🎸 toggle of displaying line graph of open positions, modify the string of toggle of displaying trading view #1342

merged 2 commits into from
Oct 17, 2023

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Oct 16, 2023 •
edited
Loading

DEVELOP

  • OpenPositionItem
  • OpenSubTab
  • OrderSection
  • PositionTab
  • TradePageBody
  • cfd/[instId]

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

@arealclimber
feat: 🎸 toggle of displaying line graph of open positions,
f7d48fd 
modify the string of toggle of displaying trading view

✅ Closes: #1337
@arealclimber arealclimber self-assigned this Oct 16, 2023
@vercel
Copy link

vercel bot commented Oct 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 9:38am

@arealclimber arealclimber linked an issue Oct 16, 2023 that may be closed by this pull request
Toggle of displaying the open position line graph #1337
Closed
Luphia
Luphia approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 595f084 into develop Oct 17, 2023
@Luphia Luphia deleted the feature/toggle-of-open-graph branch October 17, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

@Julian0701 Julian0701 Awaiting requested review from Julian0701

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toggle of displaying the open position line graph
2 participants
@arealclimber @Luphia