Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/open position modal #1360

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Feature/open position modal #1360

merged 6 commits into from
Oct 19, 2023

Conversation

Julian0701
Copy link
Member

@Julian0701 Julian0701 commented Oct 19, 2023 •
edited
Loading

DEVELOP

  • PositionOpenModal

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • high risk: 0
  • new sql: 0

UML

@Julian0701 Julian0701 self-assigned this Oct 19, 2023
@vercel
Copy link

vercel bot commented Oct 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 9:13am

@Julian0701 Julian0701 linked an issue Oct 19, 2023 that may be closed by this pull request
[BUG] Header notification layer and profile layer overlap #1335
Closed
This was linked to issues Oct 19, 2023
Update Open Position Modal Layout #1319
Closed
[BUG] My asset position error #1336
Closed
Luphia
Luphia approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit c1e8e8c into develop Oct 19, 2023
@Luphia Luphia deleted the feature/open_position_modal branch October 19, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

Assignees

@Julian0701 Julian0701

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Julian0701 @Luphia