Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 error handling when data from api is undefined #1370

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix: 🐛 error handling when data from api is undefined #1370

merged 1 commit into from
Oct 20, 2023

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Oct 20, 2023 •
edited
Loading

DEVELOP

  • userContext
  • marketContext

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

@arealclimber arealclimber self-assigned this Oct 20, 2023
@vercel
Copy link

vercel bot commented Oct 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 6:53am

@arealclimber arealclimber marked this pull request as ready for review October 20, 2023 06:53
@arealclimber arealclimber linked an issue Oct 20, 2023 that may be closed by this pull request
Exception handling of calling API #1369
Closed
Luphia
Luphia approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 845d049 into develop Oct 20, 2023
@Luphia Luphia deleted the feature/result-exception branch October 20, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

@Julian0701 Julian0701 Awaiting requested review from Julian0701

@RexBearIU RexBearIU Awaiting requested review from RexBearIU

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception handling of calling API
2 participants
@arealclimber @Luphia