Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/update gsl necessarily 1 #1427

Merged
merged 5 commits into from
Nov 19, 2023
Merged

Fix/update gsl necessarily 1 #1427

merged 5 commits into from
Nov 19, 2023

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Nov 16, 2023 •
edited
Loading

DEVELOP

  • TradeTab
  • PositionOpenModal
  • UpdateFormModal
  • PositionUpdateModal
  • ReserveRatio
  • BoardPageBody
  • NavBar

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

@arealclimber arealclimber self-assigned this Nov 16, 2023
@vercel Vercel
Copy link

vercel bot commented Nov 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2023 9:28am

@arealclimber arealclimber marked this pull request as draft November 16, 2023 06:20
@arealclimber arealclimber mentioned this pull request Nov 16, 2023
Closed
This was linked to issues Nov 16, 2023
在每次可能收保證停損手續費時重新拿一次保證停損手續費率的資料 #1417
Closed
開倉確認視窗邏輯調整跟下單區 UI 調整 #1426
Closed
[BUG] SafeMath.isNumber 誤判負數不是數字 #1428
Closed
@arealclimber arealclimber added this to the v0.8.0 Alpha milestone Nov 16, 2023
@arealclimber arealclimber marked this pull request as ready for review November 16, 2023 09:28
@arealclimber arealclimber linked an issue Nov 16, 2023 that may be closed by this pull request
NavBar, User UI 調整 #1430
Closed
5 tasks
Luphia
Luphia approved these changes Nov 19, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 8391082 into develop Nov 19, 2023
@Luphia Luphia deleted the fix/update-gsl-necessarily-1 branch November 19, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

@Julian0701 Julian0701 Awaiting requested review from Julian0701

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
v0.8.0 Alpha
2 participants
@arealclimber @Luphia