Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 💡 optimize the initialization of website view #1446

Merged
merged 2 commits into from
Nov 27, 2023
Merged

refactor: 💡 optimize the initialization of website view #1446

merged 2 commits into from
Nov 27, 2023

Conversation

arealclimber
Copy link
Member

@arealclimber arealclimber commented Nov 24, 2023 •
edited
Loading

DEVELOP

pages

  • 404
  • 500
  • coming-soon
  • index
  • leaderboard
  • my-assets
  • news
  • trade/cfd/[instId]
  • news/[newsId]

CHECK LIST

  • Naming convention verification: checked
  • Coding style verification: checked
  • new Library: 0
  • new Class / Component: 0
  • new loop: 0
  • new recursive: 0
  • high risk: 0
  • new sql: 0

UML

@vercel Vercel
Copy link

vercel bot commented Nov 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tidebit-defi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 9:47am

@arealclimber arealclimber linked an issue Nov 24, 2023 that may be closed by this pull request
優化初始化網站的頁面 #1444
Closed
@arealclimber arealclimber self-assigned this Nov 24, 2023
@arealclimber arealclimber marked this pull request as ready for review November 24, 2023 09:29
Luphia
Luphia approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@Luphia Luphia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • no bug found

@Luphia Luphia merged commit 66d93ab into develop Nov 27, 2023
2 of 8 checks passed
@Luphia Luphia deleted the refatcor/init-page branch November 27, 2023 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luphia Luphia Luphia approved these changes

@TzuHanLiang TzuHanLiang Awaiting requested review from TzuHanLiang

@Julian0701 Julian0701 Awaiting requested review from Julian0701

Assignees

@arealclimber arealclimber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

優化初始化網站的頁面
2 participants
@arealclimber @Luphia